Add stream to Parser.Error, enabling nicer error messages.#125
Open
AmosNico wants to merge 1 commit into
Open
Conversation
… output (parts of) the stream when displaying error messages.
1ba4010 to
ebabfcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the stream to
Parser.Erroras follows:This makes it possible to use (parts of) the stream when displaying error messages. This is particular useful in string parsers, where it would enable displaying the line where the error occurred. While I have not tested performance yet, I expect that the change should not effect performance to much, assuming that the underlying stream is not modified.
This is especially the case for #124, but even without this pr I think at most some references to the underlying
String/Array/... and some positions will be duplicated.If there is interest, I would be happy to make a pr adding nicer error formatting for string parsers to the library.