fix: send full record for graduation wizard academic edits (ENH-011) - #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the graduation wizard silently failing to update last-semester academic corrections in Neo Feeder (issue #117).
Graduation::finish()previously pushed per-semester academic edits (status / IPK / IPS) as a partialUpdatePerkuliahanMahasiswarecord (onlyid_status_mahasiswa,ips,ipk). Neo Feeder rejects partial records — live it enforcesid_status_mahasiswa,biaya_kuliah_smtandid_pembiayaaneven though GetDictionary lists onlyid_status_mahasiswaas NOT NULL — so every academic edit failed and the last-semester IPK/status was never actually updated. The failure was also invisible because the response was discarded and no result row was recorded.Now
finish()sends the full activity row (minus the composite key) plusid_pembiayaanresolved once per student viaGetListRiwayatPendidikanMahasiswa, with only the edited fields overridden — the same record shape proven in the Verifikasi IPK menu — and records a per-semester success/failure result so the guidance page shows exactly what happened.Checklist
Notes
Graduation.php,CHANGELOG.md);ARCHITECTURE.md/STRUCTURE.mdintentionally left unstaged.Fixes #117