Skip to content

fix: send full record for graduation wizard academic edits (ENH-011) - #118

Merged
ffooll-bit merged 1 commit into
mainfrom
fix/wizard-academic-update
Aug 31, 2026
Merged

fix: send full record for graduation wizard academic edits (ENH-011)#118
ffooll-bit merged 1 commit into
mainfrom
fix/wizard-academic-update

Conversation

@ffooll-bit

Copy link
Copy Markdown
Owner

Summary

Fixes the graduation wizard silently failing to update last-semester academic corrections in Neo Feeder (issue #117).

Graduation::finish() previously pushed per-semester academic edits (status / IPK / IPS) as a partial UpdatePerkuliahanMahasiswa record (only id_status_mahasiswa, ips, ipk). Neo Feeder rejects partial records — live it enforces id_status_mahasiswa, biaya_kuliah_smt and id_pembiayaan even though GetDictionary lists only id_status_mahasiswa as NOT NULL — so every academic edit failed and the last-semester IPK/status was never actually updated. The failure was also invisible because the response was discarded and no result row was recorded.

Now finish() sends the full activity row (minus the composite key) plus id_pembiayaan resolved once per student via GetListRiwayatPendidikanMahasiswa, with only the edited fields overridden — the same record shape proven in the Verifikasi IPK menu — and records a per-semester success/failure result so the guidance page shows exactly what happened.

Checklist

  • Implementation on a branch from main with a single atomic conventional commit
  • Local CI green: php -l, php-cs-fixer (0 fixes), phpunit 36/36
  • Live Neo Feeder verification deliberately skipped - all data is already in sync and no mutation is desired

Notes

Fixes #117

@ffooll-bit
ffooll-bit merged commit 780b217 into main Aug 31, 2026
1 check passed
@ffooll-bit
ffooll-bit deleted the fix/wizard-academic-update branch August 31, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graduation wizard academic edits fail silently (partial UpdatePerkuliahanMahasiswa record)

1 participant