feat: fill missing thesis grade from graduation Excel (ENH-010) - #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
nilai_skripsiletter-grade column to the PISN graduation Excel template and fills in a registered-but-ungraded thesis/skripsi course at submission time.Graduation:EXCEL_HEADERS/downloadTemplate/parseExcelrecognise a 5thnilai_skripsicolumn (stored uppercased per student); new privatefindMissingGradeThesis()resolves the thesis course that is still ungraded and returns its composite key;finish()pushes the Excel value viaUpdateNilaiPerkuliahanKelasonly when the grade is currently missing.NeoFeeder: newupdateNilaiPerkuliahanKelas($token, $idRegistrasi, $idKelas, $record)usingsendMutation('UpdateNilaiPerkuliahanKelas', ...)with the composite keyid_registrasi_mahasiswa+id_kelas_kuliah(schema verified live via GetDictionary).wizard.php: card 3 shows the Excel value with a "(akan diisi)" tag on an ungraded thesis row.Related issues
Fixes #110
Checklist
php -lpasses on all modified PHP filesnpm run buildsucceeds and committed assets are up to date (no asset changes)php spark routesshows correct new routes (if routes changed) (no route changes)vendor/bin/php-cs-fixer fixpasses (no style violations)vendor/bin/phpunitis green (36/36)dd(),var_dump(),console.log(),print_r(),exit()csrf_field()(no new forms)esc()Screenshot (if applicable)
Not included — verified via Playwright (non-mutating): uploading a file with the
nilai_skripsicolumn parses cleanly and card 3 renders the thesis row correctly.Notes for reviewers
nilai_huruf/nilai_angkaempty) and a value was provided in the Excel column; students without a value are left untouched.id_registrasi_mahasiswa+id_kelas_kuliah) is sourced from the cloud transcript row returned bygetCekTranskripMahasiswa(verified live on NIM 202010087).Berikutnya/finish()on real data); the push path was covered by a read-only reflection check offindMissingGradeThesis()(all cases pass) and local CI.