docs: record, verify, and sync ENH-010 graduation thesis grade feature - #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records, verifies, and syncs improvement ENH-010 — allowing a missing thesis/skripsi grade to be filled in at the end of the PISN Graduation wizard.
docs: record ENH-010— logs the idea (problem: a thesis course can exist in the transcript with no grade and the wizard offers no way to fill it; fix plan: a new Excel column holding the letter grade, shown on the transcript step, pushed at finish).docs: verify ENH-010— deep-verified against the app code and the live Neo Feeder WSGetDictionary. Confirmed theUpdateNilaiPerkuliahanKelasact: composite keyid_registrasi_mahasiswa+id_kelas_kuliah, record carryingnilai_huruf/nilai_angka/nilai_indeks. Both key values (id_reg_pd,id_kls) are available directly on the cloudnilai_mahasiswathesis row (verified live), so no extra lookup is needed. Actual Fix updated accordingly.docs: sync ENH-010 issue #110 into tracker— records the GitHub issue number on the tracker item.This is documentation-only (tracker file
docs/IMPROVEMENTS.md). No application code is changed.Checklist
php -lpasses on all modified PHP files (no PHP changed)docs/IMPROVEMENTS.md, plus the new GitHub issue Graduation wizard: allow filling in a missing thesis grade #110)docs/improvements)Notes for reviewers
The associated change will be implemented by the Code Implementation workflow. The referenced issue (#110) is intentionally left open here and will be closed when implemented.