feat: sync last-semester IPK with graduation input and auto-update status (ENH-006) - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync the student's "last semester IPK" as a single, two-way synced source shared between the step 5 graduation IPK input and the last (newest) academic row in the step 2 table. When the last academic row is still active and its IPK differs from the Excel IPK, an "Auto-update IPK & status ke Aktif" button stages the Excel IPK and the Aktif status for that row; when the row is inactive, only an informational warning is shown. The staged value flows through the existing
stepPost→finish()deferred push, so no mutation happens until submission.Related issues
Fixes #100
Checklist
php -lpasses on all modified PHP filesnpm run buildsucceeds and committed assets are up to datephp spark routesshows correct new routes (if routes changed)vendor/bin/php-cs-fixer fixpasses (no style violations)vendor/bin/phpunitis green (if tests exist): 36/36dd(),var_dump(),console.log(),print_r(),exit()csrf_field()esc()Screenshot (if applicable)
Not attached (no Neo Feeder mutation; wizard session cancelled before advancing).
Notes for reviewers
$statusOptions, label match) instead of hardcoding'A'— consistent with the design decision that the table's own input is the source of truth for status.finish()/stepPost(): the synced IPK and status are captured normally onstepPostand pushed by the existing per-semesterupdatePerkuliahanMahasiswaloop atfinish().