🧹 [Code Health]: Reduce nesting and duplication in test_utils.rs#117
Conversation
Extract repeated, deeply nested closure logic for mock route handlers in `src/apply/test_utils.rs` into `mock_handler!` and `mock_error_handler!` macros. This improves code health and readability by flattening the axum routing definitions. Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 33 33
Lines 2267 2267
=======================================
Hits 2110 2110
Misses 157 157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🧹 What: Extracted repetitive, deeply nested closures in
src/apply/test_utils.rsinto two macros:mock_handler!andmock_error_handler!.💡 Why: The codebase previously duplicated an identical nested structure (capturing an
Arcclone, usingmove ||, and returning anasync moveblock) over 15 times, leading to 6+ levels of indentation and making the mock server setup difficult to read.✅ Verification: Verified the code using
cargo test,cargo clippy, andcargo fmt. All functionality remained identical as the macro exactly mirrors the previous inline implementation.✨ Result: Substantially improved code maintainability and readability without any functional changes.
PR created automatically by Jules for task 6419688470836764877 started by @ffalcinelli