Skip to content

🧹 [Code Health]: Reduce nesting and duplication in test_utils.rs#117

Merged
ffalcinelli merged 1 commit into
mainfrom
refactor/test-utils-macros-6419688470836764877
Jun 1, 2026
Merged

🧹 [Code Health]: Reduce nesting and duplication in test_utils.rs#117
ffalcinelli merged 1 commit into
mainfrom
refactor/test-utils-macros-6419688470836764877

Conversation

@ffalcinelli
Copy link
Copy Markdown
Owner

🧹 What: Extracted repetitive, deeply nested closures in src/apply/test_utils.rs into two macros: mock_handler! and mock_error_handler!.
💡 Why: The codebase previously duplicated an identical nested structure (capturing an Arc clone, using move ||, and returning an async move block) over 15 times, leading to 6+ levels of indentation and making the mock server setup difficult to read.
Verification: Verified the code using cargo test, cargo clippy, and cargo fmt. All functionality remained identical as the macro exactly mirrors the previous inline implementation.
Result: Substantially improved code maintainability and readability without any functional changes.


PR created automatically by Jules for task 6419688470836764877 started by @ffalcinelli

Extract repeated, deeply nested closure logic for mock route handlers
in `src/apply/test_utils.rs` into `mock_handler!` and `mock_error_handler!`
macros. This improves code health and readability by flattening the
axum routing definitions.

Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (113c547) to head (00c1d7d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files          33       33           
  Lines        2267     2267           
=======================================
  Hits         2110     2110           
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ffalcinelli ffalcinelli merged commit 5131fad into main Jun 1, 2026
9 checks passed
@ffalcinelli ffalcinelli deleted the refactor/test-utils-macros-6419688470836764877 branch June 1, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant