Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"tailwindcss": "^4.1.18",
"tailwindcss-animate": "^1.0.7",
"typescript": "^6.0.0",
"vite-plus": "0.1.21",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description mentions updating vite and vitest aliases to their respective @voidzero-dev/* pkg-pr-new URLs via overrides or resolutions. However, these changes are not present in the package.json file. Without these overrides, the project and its dependencies will continue to use the standard versions of vite and vitest instead of the prerelease versions from the PR.

"vue-tsc": "~3.2.2"
},
"engines": {
Expand Down
116 changes: 67 additions & 49 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
verifyDepsBeforeRun: install
packages:
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Comment on lines +3 to +6

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The minimumReleaseAge configuration is placed in pnpm-workspace.yaml. However, standard package managers like pnpm, npm, and bun do not recognize this file for general configuration; they typically use .npmrc (with the key minimum-release-age) or bunfig.toml. Furthermore, the current indentation level places these new keys at the same level as packages:, which effectively nullifies the packages definition and may break workspace detection. If these settings are intended for the package managers as stated in the PR description, they should be moved to the appropriate configuration files.

Loading