Skip to content

chore(deps): bump vite-plus to v0.2.2#17

Draft
fengmk2 wants to merge 5 commits into
masterfrom
update-vite-plus-prerelease-test-0.2.2
Draft

chore(deps): bump vite-plus to v0.2.2#17
fengmk2 wants to merge 5 commits into
masterfrom
update-vite-plus-prerelease-test-0.2.2

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg.pr.new prerelease build for v0.2.2 (registry-bridge commit build) to smoke-test the prerelease.

  • vite-plus + vite (alias to @voidzero-dev/vite-plus-core) and vitest pinned to the commit build across deps / overrides / catalogs
  • minimumReleaseAge enabled with the vite-plus / @voidzero-dev/* / oxc / oxlint stack excluded
  • .npmrc (or .yarnrc.yml) points the package manager at the registry bridge (prerelease scaffolding)

Test plan

  • CI passes

phanan and others added 5 commits July 1, 2026 21:46
* fix: populate starred date on Subsonic songs, albums and artists

* fix: populate played date on Subsonic albums

* refactor: use query builder for exists clause and index interactions for last-played lookups
…#2602)

* fix: read DATE vorbis tag for year when scanning FLAC/OGG files

* test: assert year is read from DATE vorbis tag when scanning FLAC

---------

Co-authored-by: Phan An <me@phanan.net>
@fengmk2 fengmk2 self-assigned this Jul 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds 'starred' and 'played' timestamps to Subsonic API resources, implements offset-based pagination in the album repository, adds a composite index to the 'interactions' table, and updates project dependencies and documentation formatting. The review feedback identifies several issues: missing imports for the 'DB' facade in 'AlbumBuilder.php' and the 'FavoriteableType' enum in 'GetStarred2Test.php', a missing 'down' method in the database migration, and an incorrect 'vitest' version in 'pnpm-workspace.yaml' that should be pinned to the commit build to prevent breaking the unified toolchain.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
vitest: 'catalog:'
catalog:
vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.1d7ba811f0e456640b0e761e8e8acf77d1ad3251
vitest: 4.1.9

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR description states that vitest is pinned to the commit build. However, in the catalog section, vitest is set to 4.1.9 (a standard semver version). This will install the standard vitest package instead of the vite-plus test wrapper (@voidzero-dev/vite-plus-test), which breaks the unified toolchain setup. It should be pinned to the corresponding commit build.

  vitest: npm:@voidzero-dev/vite-plus-test@0.0.0-commit.1d7ba811f0e456640b0e761e8e8acf77d1ad3251

throw_unless($this->user, new LogicException('User must be set to query last played timestamps.'));

return $this->addSelect([
'last_played_at' => DB::table('interactions')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The DB facade is used here but is not imported in this file. Since DB was not previously used in AlbumBuilder.php, this will cause a runtime error (Class "App\Builders\DB" not found). We should fully qualify it as \Illuminate\Support\Facades\DB or import it at the top of the file.

            'last_played_at' => \\Illuminate\\Support\\Facades\\DB::table('interactions')

Comment on lines +87 to +106
Favorite::factory()->createMany([
[
'user_id' => $user->id,
'favoriteable_type' => FavoriteableType::PLAYABLE->value,
'favoriteable_id' => $song->id,
'created_at' => $favoritedAt,
],
[
'user_id' => $user->id,
'favoriteable_type' => FavoriteableType::ALBUM->value,
'favoriteable_id' => $album->id,
'created_at' => $favoritedAt,
],
[
'user_id' => $user->id,
'favoriteable_type' => FavoriteableType::ARTIST->value,
'favoriteable_id' => $artist->id,
'created_at' => $favoritedAt,
],
]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The FavoriteableType enum is used in this new test, but it is not imported at the top of GetStarred2Test.php. This will cause a test failure (Class "Tests\Feature\Subsonic\FavoriteableType" not found). We should fully qualify it as \App\Enums\FavoriteableType.

        Favorite::factory()->createMany([
            [
                'user_id' => $user->id,
                'favoriteable_type' => \\App\\Enums\\FavoriteableType::PLAYABLE->value,
                'favoriteable_id' => $song->id,
                'created_at' => $favoritedAt,
            ],
            [
                'user_id' => $user->id,
                'favoriteable_type' => \\App\\Enums\\FavoriteableType::ALBUM->value,
                'favoriteable_id' => $album->id,
                'created_at' => $favoritedAt,
            ],
            [
                'user_id' => $user->id,
                'favoriteable_type' => \\App\\Enums\\FavoriteableType::ARTIST->value,
                'favoriteable_id' => $artist->id,
                'created_at' => $favoritedAt,
            ],
        ]);

Comment on lines +7 to +14
return new class extends Migration {
public function up(): void
{
Schema::table('interactions', static function (Blueprint $table): void {
$table->index(['song_id', 'user_id', 'last_played_at']);
});
}
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This migration lacks a down() method to drop the newly added composite index. To ensure the migration is reversible and supports rollback functionality, please add a down() method.

return new class extends Migration {
    public function up(): void
    {
        Schema::table('interactions', static function (Blueprint $table): void {
            $table->index(['song_id', 'user_id', 'last_played_at']);
        });
    }

    public function down(): void
    {
        Schema::table('interactions', static function (Blueprint $table): void {
            $table->dropIndex(['song_id', 'user_id', 'last_played_at']);
        });
    }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants