Skip to content

vp migrate beta test #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

vp migrate beta test #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh)
registry=https://pkg-pr-registry-bridge.render.vip/
1 change: 1 addition & 0 deletions .vite-hooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
vp staged
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"sharp": "^0.33.4",
"tailwindcss": "^3.4.3",
"typescript": "^5.4.5",
"vite": "catalog:"
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.c0a3a57de28c581e83ba2dc359311d67af46e6c4"
},
"devDependencies": {
"@astrojs/check": "^0.9.4",
Expand Down
26 changes: 22 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,38 @@
"test": "vp test",
"fix": "vp check --fix",
"check": "vp check",
"publint": "pnpm --recursive --filter=\"./packages/**\" exec publint"
"publint": "pnpm --recursive --filter=\"./packages/**\" exec publint",
"prepare": "vp config"
},
"devDependencies": {
"@changesets/cli": "^2.31.0",
"@rspack/cli": "^1.7.3",
"@rspack/core": "^1.7.3",
"@svitejs/changesets-changelog-github-compact": "^1.2.0",
"@typescript/native-preview": "7.0.0-dev.20260421.2",
"@vitest/browser-playwright": "4.1.9",
"esbuild": "catalog:",
"playwright": "^1.58.0",
"publint": "^0.3.17",
"typescript": "catalog:",
"vite-plus": "catalog:",
"vitest": "catalog:"
"vite-plus": "0.0.0-commit.c0a3a57de28c581e83ba2dc359311d67af46e6c4",
"vitest": "4.1.9"
},
"packageManager": "pnpm@9.10.0"
"packageManager": "pnpm@9.10.0",
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.c0a3a57de28c581e83ba2dc359311d67af46e6c4",
"vitest": "4.1.9"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
}
}
4 changes: 2 additions & 2 deletions packages/anywidget/__tests__/widget.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as widgets from "@jupyter-widgets/base";
import * as baseManager from "@jupyter-widgets/base-manager";
import { afterEach, expect, it } from "vitest";
import { page, userEvent } from "vitest/browser";
import { afterEach, expect, it } from "vite-plus/test";
import { page, userEvent } from "vite-plus/test/browser";

import createAnywidget from "../src/widget.js";

Expand Down
3 changes: 2 additions & 1 deletion packages/anywidget/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
},
"devDependencies": {
"@jupyter-widgets/base": "^6",
"@jupyter-widgets/base-manager": "^1.0.12"
"@jupyter-widgets/base-manager": "^1.0.12",
"vitest": "4.1.9"
Comment on lines +30 to +31

@gemini-code-assist gemini-code-assist Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the imports in packages/anywidget/__tests__/widget.test.ts have been migrated from vitest to vite-plus/test, vitest is no longer directly imported in this package. Consider removing vitest from devDependencies to avoid unused dependencies.

    "@jupyter-widgets/base-manager": "^1.0.12"

},
"jupyterlab": {
"extension": "./src/plugin.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/types/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { describe, expectTypeOf, it } from "vitest";
import { describe, expectTypeOf, it } from "vite-plus/test";

import type { AnyModel, AnyWidget, Host } from "./index.ts";

Expand Down
2 changes: 1 addition & 1 deletion packages/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}
},
"devDependencies": {
"vite": "catalog:"
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.c0a3a57de28c581e83ba2dc359311d67af46e6c4"
},
"peerDependencies": {
"vite": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0"
Expand Down
5 changes: 5 additions & 0 deletions packages/vue/env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
declare module "*.vue" {
import type { DefineComponent } from "vue";
const component: DefineComponent<{}, {}, unknown>;

@gemini-code-assist gemini-code-assist Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using unknown as the third generic argument (D / Data) for DefineComponent can be overly restrictive for a general wildcard module declaration, as it might force consumers to cast or handle unknown types when accessing component instance data. Using any is more standard for wildcard shims to ensure smooth integration.

Suggested change
const component: DefineComponent<{}, {}, unknown>;
const component: DefineComponent<{}, {}, any>;

export default component;
}
3 changes: 3 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { defineConfig } from "vite-plus";
import { playwright } from "vite-plus/test/browser-playwright";

export default defineConfig({
staged: {
"*": "vp check --fix",
},
fmt: {
experimentalSortImports: {},
ignorePatterns: ["CHANGELOG.md"],
Expand Down
Loading