Optimize local sinkhole - #7
Open
qijuechenwsp wants to merge 3 commits into
Open
Conversation
thwllms
requested changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
@qijuechenwsp working well, I think! Agree that output does look reasonable. Comments:
raster/__init__.pyis large and a little hard to follow. Can we organize these functions into multiple submodules?- I'm not certain that the final watershed clip is working. Can you look into that?
- I think we might want to avoid working with Pandas/GeoPandas here, since we're dealing with really large scale. See if we can avoid Pandas/GeoPandas by working with gdal/ogr only.
Contributor
Author
|
@thwllms I rid of any shapely or geopandas usage, separated functions into submodules, and then fixed the watershed clipping so it doesn't generate/copy over watershed boundary when there's no overflow etc. PR ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local test using stage_Step = 5 and tool run on small input raster successfully. Output looks reasonable, but in need of further review.