Fix issues in comment area#879
Open
kaorahi wants to merge 5 commits into
Open
Conversation
added 5 commits
March 9, 2021 21:45
kaorahi
pushed a commit
to kaorahi/lizzie
that referenced
this pull request
Mar 12, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue A:
#676 (word wrap). Compared to #696, this PR will be more friendly with the existing code of Lizzie 0.7.4.
Issue B:
In Panel UI, comments with many lines are scrolled to the bottom initially. The top lines should be visible initially for convenience.
(Try the sample SGF in #877.)
Issue C:
On Lizzie 0.7.4,
score 5is shown in the comment area by the following SGF due to insufficient HTML escaping. It should bescore < 5.Issue D:
I expect nothing happens in the step 3.
In addition, this PR may also help future implementation of #806. (only in Panel UI because of #877)
I dare to keep the obsolete name
commentPane, that is not JTextPane but JTextArea now. I'd like to make changes as small as possible to avoid conflicts with other patches.