Frontend rewrite - #131
Open
lieberlois wants to merge 16 commits into
Open
Conversation
lieberlois
marked this pull request as ready for review
March 19, 2023 10:05
|
creeDocker image is available as
|
BlacCello
reviewed
Oct 5, 2023
| private MAX_IMAGES_DISPLAYED: number = 15; | ||
| private firstImageDisplayed: number = 0; | ||
|
|
||
| public nextButtonEnabled: boolean = true; |
There was a problem hiding this comment.
This is not a good default value if there is only one page (however, this is currently also a problem with the old frontend)
BlacCello
reviewed
Oct 5, 2023
| selectedLink: string; | ||
| public selectedLink: string; | ||
|
|
||
| public previewVisible: boolean = true; |
There was a problem hiding this comment.
Suggested change
| public previewVisible: boolean = true; | |
| public previewVisible: boolean = false; |
BlacCello
reviewed
Oct 5, 2023
| public displayImage; | ||
| public selectedLink: string; | ||
|
|
||
| public previewVisible: boolean = true; |
There was a problem hiding this comment.
Suggested change
| public previewVisible: boolean = true; | |
| public previewVisible: boolean = false; |
BlacCello
reviewed
Oct 5, 2023
| } | ||
| } | ||
|
|
||
| enum TransformationType { |
There was a problem hiding this comment.
You can think about moving those classes into separate file(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.