feat(security): enforce pragmatic domain-level network boundaries via static ESLint rules - #768
Open
google-labs-jules[bot] wants to merge 2 commits into
Conversation
…ESLint boundaries
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
equipose | e40f611 | Commit Preview URL Branch Preview URL |
Aug 11 2026, 09:42 PM |
…n level boundaries and preventing empty source nodes
Contributor
Author
|
[CI/CD Fix] We've resolved the documentation sync failure by making the following improvements:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pragmatic Domain-Level Boundaries
This PR implements compile-time/lint-time restriction of client-side network egress paths in core simulation domains to enforce the offline-first zero-trust guarantee.
1. Key Implementations
eslint.config.jsUpdate: Added a dedicated rule block targetingsrc/app/domain/**/*.ts(excluding update infrastructure which is outside/domain).no-restricted-globals): Blocks usage of raw global network clients:fetchXMLHttpRequestWebSocketEventSourceno-restricted-properties): Blocks access via namespaces or browser properties:window.fetch/globalThis.fetchwindow.XMLHttpRequest/globalThis.XMLHttpRequestnavigator.sendBeacon(matches any property namedsendBeacon)no-restricted-imports): Blocks importing@angular/common/httpand@angular/common/http/*.@angular/common/httprestrictions into the existing more specific nested domain blocks (e.g.,study-builderandschema-management) to prevent nested rules overriding/bypassing these global checks.2. Validation & Verification
/src/app/domain/shared/statistical/largest-remainder.tsto test each restricted global, property, and import. ESLint successfully detected all of them and threw immediate descriptive errors.src/app/core/services/update-notification.service.tswhich successfully utilizesfetchto query for PWA update manifests. Since it lies outside thesrc/app/domain/directory, it is exempt from the restrictions and requires absolutely zero inline ESLint override comments (e.g./* eslint-disable */).