Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5429fb139d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| func supportedShellStatement(statement *syntax.Stmt) bool { | ||
| if statement == nil || statement.Negated || statement.Background || statement.Coprocess || statement.Disown || | ||
| len(statement.Redirs) != 0 { |
There was a problem hiding this comment.
When a build-log line contains an unrelated redirected command before an independently sequenced compilation, such as printf 'status' >&2; gcc -c a.c, this condition makes supportedShellCommandList reject the entire AST, so Parse never reaches the compiler command and silently omits a real database entry. This commit even removes equivalent printf ... 1>&2; prefixes from tests/build.log; reject or conservatively summarize only the redirected statement instead of discarding independent statements on the same line.
AGENTS.md reference: AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
1 participant
No description provided.