[#442][FIX] 사전의견 빈 토픽 제출 허용 - #443
Merged
Merged
Conversation
공유하기(제출) 시 topicIds가 비어 있으면 @notempty 검증에 걸려 G002 "비어 있을 수 없습니다" 오류로 제출이 불가했다. 커밋 6f3d7c8(빈 사전답변 제출 가능) 의도에 맞춰 제약을 정리한다. - TopicAnswerBulkSubmitRequest: topicIds @notempty 제거 - TopicAnswerService.submitAnswersBulk: topicIds null-safe 처리 - TopicAnswerServiceTest: 빈 리스트/null 제출 케이스 추가 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 요약
이슈 번호
Closes #442
주요 변경 사항
TopicAnswerBulkSubmitRequest:topicIds의@NotEmpty제거 — 빈 토픽 목록 제출 허용 (보고된 G002의 직접 원인)TopicAnswerService.submitAnswersBulk:topicIdsnull-safe 처리 (FE가 null 전송 시 NPE 방지, save 경로와 동일 패턴)TopicAnswerServiceTest: 빈 리스트/null 제출 정상 동작 케이스 2건 추가참고 사항
review/keywordIds)는 기존대로 필수 유지 — 커밋 의도가 "토픽 답변"에 한정되어 범위에서 제외. 책평가를 선택값으로 전환할지는 별도 기획 결정 필요../gradlew test --tests "com.dokdok.topic.service.TopicAnswerServiceTest"통과