Skip to content

SagePatch: pin target to C++17 so macOS builds #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbraz3 merged 1 commit into from
Jun 28, 2026
Merged

SagePatch: pin target to C++17 so macOS builds #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Patches/SagePatch/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ endif()

add_library(sage_patch SHARED ${SAGE_PATCH_SOURCES})

# SagePatch sources use modern C++ (scoped enums, brace-init). The legacy engine
# builds at C++98, and without pinning a standard here the target inherits it,
# so a standards-strict compiler (e.g. AppleClang) fails to build sage_patch with
# "scoped enumerations are a C++11 extension". Pin this target to C++17.
set_target_properties(sage_patch PROPERTIES
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
)

target_include_directories(sage_patch PRIVATE
include
${CMAKE_BINARY_DIR}/_deps/sdl3-src/include
Expand Down