Use consistent borders for app popovers#5971
Open
ComputelessComputer wants to merge 1 commit into
Open
Conversation
Remove the 3px override so app popovers match shared floating surfaces.
✅ Deploy Preview for old-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the 3px override so app popovers match shared floating surfaces.
Note
Low Risk
Visual-only styling in the UI package with no auth, data, or behavior changes.
Overview
App-variant popovers now use the shared
appFloatingContentClassNamestyling without a thicker border override, so they match other app floating UI (e.g. dropdowns) instead of rendering a 3px border.The shared floating chrome token also bumps corner radius from 18px to 22px, which applies anywhere that class is used—not only popovers.
Reviewed by Cursor Bugbot for commit 1904159. Bugbot is set up for automated code reviews on this repo. Configure here.