fix(types): add optional value to MultipartFile for onFile - #624
Open
imharjot wants to merge 3 commits into
Open
fix(types): add optional value to MultipartFile for onFile#624imharjot wants to merge 3 commits into
imharjot wants to merge 3 commits into
Conversation
Tony133
approved these changes
Jul 16, 2026
is2ei
reviewed
Jul 23, 2026
is2ei
left a comment
Contributor
There was a problem hiding this comment.
I think the issue is a bit more complicated.
It looks like assigning the value field to the part object in the onFile function is a bit of a hack.
This works because the if statement uses field.value when it is not undefined.
https://github.com/fastify/fastify-multipart/blob/main/index.js#L100-L103
if (field.value !== undefined) {
body[key] = field.value
} else if (field._buf) {
body[key] = field._bufHowever, the value property is intended for objects whose type is field.
https://github.com/fastify/fastify-multipart/blob/main/index.js#L338-L347
const value = {
type: 'field',
fieldname: name,
mimetype: contentType,
encoding,
value: fieldValue,
fieldnameTruncated,
valueTruncated,
fields: body
}On the other hand, the _buf property is intended for objects whose type is file.
https://github.com/fastify/fastify-multipart/blob/main/index.js#L373-L382
const value = {
type: 'file',
fieldname: name,
filename,
encoding,
mimetype,
file,
fields: body,
_buf: null,
async toBuffer () {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README documents setting
part.valueinside anonFilehandler when usingattachFieldsToBody: 'keyValues', butMultipartFilehas novalueproperty, so thatexample fails to typecheck with TS2339 (
Property 'value' does not exist on type 'MultipartFile').Adds an optional
value?: unknowntoMultipartFile.unknown(notany) keeps ittype-safe and matches the existing
Record<string, unknown>usage in this file; it'soptional because a file part only gets a
valuewhen one is assigned inonFile. KeptMultipartFilenon-generic to avoid rippling generics throughMultipart/MultipartFields.The existing type test asserted
req.body.filehad novalue, so that assertion is flippedand the
onFiletest handler now assignspart.valueto cover the regression.Fixes #574