Skip to content

chore: nuke entire skills package from codebase#120

Closed
bedus-creation wants to merge 1 commit into
mainfrom
cleanup/remove-skills-package
Closed

chore: nuke entire skills package from codebase#120
bedus-creation wants to merge 1 commit into
mainfrom
cleanup/remove-skills-package

Conversation

@bedus-creation

Copy link
Copy Markdown
Contributor

Summary

  • Removes fastapi_startkit/src/fastapi_startkit/skills/ (12 files: package, adapters, commands, parser, provider, registry, SKILL.md stubs)
  • Removes fastapi_startkit/tests/skills/ (5 files: test_adapters, test_commands, test_parser, test_registry, init)
  • No changes needed to pyproject.toml (no [skills] extra existed)
  • No changes needed to example/ai-agent-app/ (.ai/ and .claude/skills/ were untracked; bootstrap/application.py had no skills imports; pyproject.toml had no skills dependency)

17 files deleted, 1 402 lines removed.

Test plan

  • Run uv run pytest fastapi_startkit/ — no skills tests remain, existing test suite should pass
  • Confirm fastapi_startkit/src/fastapi_startkit/skills/ directory is gone
  • Confirm fastapi_startkit/tests/skills/ directory is gone

🤖 Generated with Claude Code

Deletes the skills source package (src/fastapi_startkit/skills/) and all
associated tests (tests/skills/). The skills feature was experimental and
is no longer needed; removing it keeps the framework lean and avoids any
maintenance burden.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@bedus-creation bedus-creation left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review by Reviewer-389 — APPROVED ✅

All checklist items verified clean.

Checklist results

Item Result
fastapi_startkit/src/fastapi_startkit/skills/ fully gone ✅ All 10 source files deleted
fastapi_startkit/tests/skills/ fully gone ✅ All 5 test files deleted
No orphaned from fastapi_startkit.skills / import skills ✅ Zero hits across entire codebase
pyproject.toml has no [skills] extra ✅ Confirmed absent
example/ai-agent-app has no .ai/ or .claude/skills/ dirs ✅ Neither is git-tracked; local artifacts only
Tests pass ✅ 1353 passed, 7 skipped, 0 failures
No unrelated files changed ✅ All 17 changed files are pure deletions within skills dirs

Notes

  • The .ai/ dir in example/ai-agent-app is untracked by git (confirmed via git ls-files --error-unmatch). The .claude/ dir is gitignored. Neither requires a PR change.
  • SQLAlchemy pool warnings in the test run are pre-existing and unrelated.
  • The diff is surgical: nothing outside skills/ touched.

Verdict: merge when ready.

@bedus-creation bedus-creation deleted the cleanup/remove-skills-package branch June 13, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant