chore: nuke entire skills package from codebase#120
Closed
bedus-creation wants to merge 1 commit into
Closed
Conversation
Deletes the skills source package (src/fastapi_startkit/skills/) and all associated tests (tests/skills/). The skills feature was experimental and is no longer needed; removing it keeps the framework lean and avoids any maintenance burden. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bedus-creation
commented
Jun 13, 2026
bedus-creation
left a comment
Contributor
Author
There was a problem hiding this comment.
Code Review by Reviewer-389 — APPROVED ✅
All checklist items verified clean.
Checklist results
| Item | Result |
|---|---|
fastapi_startkit/src/fastapi_startkit/skills/ fully gone |
✅ All 10 source files deleted |
fastapi_startkit/tests/skills/ fully gone |
✅ All 5 test files deleted |
No orphaned from fastapi_startkit.skills / import skills |
✅ Zero hits across entire codebase |
pyproject.toml has no [skills] extra |
✅ Confirmed absent |
example/ai-agent-app has no .ai/ or .claude/skills/ dirs |
✅ Neither is git-tracked; local artifacts only |
| Tests pass | ✅ 1353 passed, 7 skipped, 0 failures |
| No unrelated files changed | ✅ All 17 changed files are pure deletions within skills dirs |
Notes
- The
.ai/dir inexample/ai-agent-appis untracked by git (confirmed viagit ls-files --error-unmatch). The.claude/dir is gitignored. Neither requires a PR change. - SQLAlchemy pool warnings in the test run are pre-existing and unrelated.
- The diff is surgical: nothing outside
skills/touched.
Verdict: merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fastapi_startkit/src/fastapi_startkit/skills/(12 files: package, adapters, commands, parser, provider, registry, SKILL.md stubs)fastapi_startkit/tests/skills/(5 files: test_adapters, test_commands, test_parser, test_registry, init)pyproject.toml(no[skills]extra existed)example/ai-agent-app/(.ai/and.claude/skills/were untracked;bootstrap/application.pyhad no skills imports;pyproject.tomlhad no skills dependency)17 files deleted, 1 402 lines removed.
Test plan
uv run pytest fastapi_startkit/— no skills tests remain, existing test suite should passfastapi_startkit/src/fastapi_startkit/skills/directory is gonefastapi_startkit/tests/skills/directory is gone🤖 Generated with Claude Code