provider-opencode-go: CodeRabbit review fixes (review before official) - #2
Merged
faramirezs merged 1 commit intoAug 4, 2026
Merged
Conversation
- iii-permissions.yaml: deny provider::opencode_go::abort (agents must not cancel router-owned streams; matches provider-claude-code) - sse.rs: relay delta.reasoning_content as thinking blocks (the OpenCode Go wire emits it, live-verified); bound tool-call index to 64 (malformed upstream could grow the vec unboundedly) - upstream.rs: data_line per SSE spec — accept data: without a space and join repeated data: lines instead of silently dropping output - curated.rs: per-model max_output_tokens from models.dev limit.output; 4096 stays the unknown-id fallback - reasoning.rs: Minimal maps to minimal then none (gpt-5.6-luna floor) - register.rs: log router::ready trigger registration failures - router_client.rs: narrow module doc claim - README: repair split provider-openai table row; III_WS_URL -> III_URL (code + engine convention); thinking-delta relay note
skill-check — worker0 verified, 54 skipped (no docs/).
Three for three. Nicely done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the 9 CodeRabbit comments on iii-hq#690 — staged here for review before the official PR moves.
Fixed (7)
provider::opencode_go::abort(Major/security — agents must not cancel router-owned streams; matches provider-claude-code, the only sibling with an abort surface)delta.reasoning_contentas thinking blocks (the OpenCode Go wire emits it — live-verified); bound tool-call index to 64 (malformed upstream could grow the vec unboundedly)data_lineper SSE spec — acceptdata:without a space, join repeateddata:lines (was silently dropping assistant output)max_output_tokensfrom models.devlimit.output(24 values); 4096 stays the unknown-id fallbackMinimalmaps tominimalthennone(gpt-5.6-luna publishesnoneas its floor) + testsrouter::readytrigger registration failures (waslet _)provider-openaitable row our port commit broke; provider READMEIII_WS_URL→III_URL(code + engine convention; sibling READMEs carry the old doc name)Skipped with reasons
harness/src/main.rs) usesIII_URL; fixed the README instead/chat/completions): the fallback only triggers for non-OpenAI-compatible paths; skipping discovery would silently stall catalog refreshes — kept the deliberate fallbackpump_abortable/StreamAborts, shared with kimi/codex); our wiring is the 2-line register + pre-spawn check — follow-upVerification