Correct unsupported v21.0 default seam metadata - #25
Merged
Conversation
Independent reconstruction found no support for treating O*NET v21.0 as a proven global content or method seam. The package's prior claim that v21.0 retired the Task Relevance scale was unsupported. - onet_known_seams() now returns only the verified v25.1 SOC-2010 to SOC-2018 taxonomy seam; the v21.0 / 2016-08-01 row is removed. - Default v20.1 -> v21.x comparisons with unchanged SOC vintage are no longer seam-flagged solely for crossing that release date. - The v25.1 taxonomy seam behavior is unchanged. - The seams = override API is unchanged: callers with channel-specific evidence can still supply a custom v21.0 row to onet_content_change() or onet_resurvey_panel(), but this is not a package-verified default. - Updated roxygen docs, regenerated Rd files, NEWS, docs/SPEC.md, and docs/DATA_NOTES.md to remove the unsupported v21.0 claims. - Regenerated the content-change fixture to match corrected default output, and added tests covering the default registry, the unflagged v20.1 -> v21.x default comparison, and the caller-supplied override. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scientific correction
Independent reconstruction in
farach/onet-vintage-biasestablished that v21.0 is not proven as a global O*NET content/method seam. The package's prior claim that v21.0 "retired the Task Relevance scale" was unsupported. This PR removes v21.0 as a package-verified default seam while preserving the verified v25.1 SOC-2010 to SOC-2018 taxonomy seam and the existingseams =override API.Changes
R/resurvey.R:onet_known_seams()now returns only the verified v25.1soc_seamrow (2020-11-01). Thescale_seam/ v21.0 / 2016-08-01 row is removed.v20.1 -> v21.xcomparisons with unchanged SOC vintage are no longer seam-flagged solely for crossing that release date; ordinary non-seam comparability rules apply.safely_comparable = FALSE).seams =override API ononet_content_change()andonet_resurvey_panel()is unchanged. A caller with channel-specific evidence can still supply a custom v21.0 row; documentation now makes explicit that such custom seams require external justification and are not package-verified defaults.R/resurvey.RandR/content_change.R, regeneratedman/onet_content_change.Rdandman/onet_resurvey_panel.Rdviadevtools::document().NEWS.md,docs/SPEC.md, anddocs/DATA_NOTES.mdprose that asserted v21.0 as a verified/default seam or claimed retirement of the Task Relevance scale. Added a NEWS bug-fix entry describing this as removal of unsupported default metadata (not a new scientific finding).tests/testthat/fixtures/content-change-valid.rdsto match the corrected default output.Scope search
Searched the entire tracked tree for
v21,21.0,2016-08-01,relevance seam,retired Task Relevance,post-v21, andsafely comparable. Confirmed matches in README.md/README.Rmd, the within-between-decomposition vignette, measure-reproducibility vignette, R/measure.R, and man/onet_task_to_occupation.Rd are unrelated (generic "task relevance" scale references or an unrelatedsafely_comparableusage inonet_panel_reconcile()), so they were left untouched.Validation
main(3 failures intest-content-change.R, 8+ intest-resurvey.Rbefore implementation).devtools::test()full suite passes:[ FAIL 0 | WARN 0 | SKIP 0 | PASS 942 ].devtools::document()run; Rd files regenerated and match roxygen source.rcmdcheck::rcmdcheck(args = "--as-cran"):1 ERROR | 1 WARNING | 1 NOTE, all from a pre-existingquarto -Vinvocation quirk inchecking DESCRIPTION meta-information(aTMPDIR=argument is misparsed as a subcommand on this Windows box) and aNew submissionNOTE. Confirmed identical result on unmodifiedmain(verified viagit stash), so this is a pre-existing environment issue, not introduced by this change.NEWS.md,R/content_change.R,R/resurvey.R,docs/DATA_NOTES.md,docs/SPEC.md,man/onet_content_change.Rd,man/onet_resurvey_panel.Rd,tests/testthat/fixtures/content-change-valid.rds,tests/testthat/test-content-change.R,tests/testthat/test-resurvey.R. No unrelated API/output change. No credentials or cache data touched. Worktree is clean after commit.Handoff
353f7cb8d0dd3fc35ff894caab52245ee3048a26(verified against remotemainbefore editing)761e77420ea0896b8d669d78926f2f58a3da708dfarach-correct-v21-seam-metadataStopping here for independent review per instructions; not merging, tagging, releasing, or deleting branches.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com