Skip to content

chore: Fix some issues with static analysis#88

Draft
jason-famedly wants to merge 24 commits into
mainfrom
jason/tech-debt-1
Draft

chore: Fix some issues with static analysis#88
jason-famedly wants to merge 24 commits into
mainfrom
jason/tech-debt-1

mypy options I was using and a read out of the current state of the m…

f1d48dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 23, 2026 in 0s

73.81% (+0.53%) compared to 84a327e

View this Pull Request on Codecov

73.81% (+0.53%) compared to 84a327e

Details

Codecov Report

❌ Patch coverage is 73.64865% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.81%. Comparing base (84a327e) to head (f1d48dc).

Files with missing lines Patch % Lines
synapse_token_authenticator/config.py 78.47% 18 Missing and 13 partials ⚠️
synapse_token_authenticator/auth_headers.py 51.06% 23 Missing ⚠️
synapse_token_authenticator/token_authenticator.py 79.36% 5 Missing and 8 partials ⚠️
synapse_token_authenticator/rest.py 65.62% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   73.28%   73.81%   +0.53%     
==========================================
  Files           5        7       +2     
  Lines         756      779      +23     
  Branches      145      146       +1     
==========================================
+ Hits          554      575      +21     
- Misses        143      145       +2     
  Partials       59       59              
Files with missing lines Coverage Δ
synapse_token_authenticator/claims_validator.py 77.60% <100.00%> (ø)
synapse_token_authenticator/utils.py 100.00% <100.00%> (+9.09%) ⬆️
synapse_token_authenticator/rest.py 65.62% <65.62%> (ø)
synapse_token_authenticator/token_authenticator.py 72.22% <79.36%> (+0.75%) ⬆️
synapse_token_authenticator/auth_headers.py 51.06% <51.06%> (ø)
synapse_token_authenticator/config.py 76.28% <78.47%> (+7.46%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a327e...f1d48dc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.