Skip to content

refactor: Add more logs#72

Merged
mzaniolo merged 1 commit into
mainfrom
mzaniolo/logs
Aug 11, 2025
Merged

refactor: Add more logs#72
mzaniolo merged 1 commit into
mainfrom
mzaniolo/logs

Conversation

@mzaniolo

@mzaniolo mzaniolo commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

While testing I was missing this log to know why the login was failing. Since we usually run the modules with info level I added one more log to help tell what's wrong. I'm not just changing the level of the bellow log because it contains the user external id

@mzaniolo
mzaniolo requested a review from a team as a code owner August 5, 2025 13:20
@codecov

codecov Bot commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.08%. Comparing base (6014680) to head (3766167).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   83.07%   83.08%           
=======================================
  Files          18       18           
  Lines        1873     1874    +1     
  Branches      193      193           
=======================================
+ Hits         1556     1557    +1     
  Misses        234      234           
  Partials       83       83           
Files with missing lines Coverage Δ
synapse_token_authenticator/token_authenticator.py 71.46% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6014680...3766167. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mzaniolo
mzaniolo merged commit 3766167 into main Aug 11, 2025
5 checks passed
@mzaniolo
mzaniolo deleted the mzaniolo/logs branch August 11, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants