Skip to content

feat(oauth): Make admin_path take multiple paths#70

Merged
mzaniolo merged 2 commits into
mainfrom
mzaniolo/admin_path
Jul 31, 2025
Merged

feat(oauth): Make admin_path take multiple paths#70
mzaniolo merged 2 commits into
mainfrom
mzaniolo/admin_path

Conversation

@mzaniolo

Copy link
Copy Markdown
Contributor

Closes: #69

@mzaniolo
mzaniolo requested a review from a team as a code owner July 29, 2025 15:48
@mzaniolo
mzaniolo force-pushed the mzaniolo/admin_path branch 2 times, most recently from adf086b to 5a1d0ef Compare July 29, 2025 16:27
@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.17544% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.07%. Comparing base (681a01d) to head (84cfe25).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
synapse_token_authenticator/claims_validator.py 63.15% 9 Missing and 5 partials ⚠️
synapse_token_authenticator/config.py 17.64% 14 Missing ⚠️
tests/__init__.py 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   82.36%   83.07%   +0.70%     
==========================================
  Files          18       18              
  Lines        1849     1873      +24     
  Branches      191      193       +2     
==========================================
+ Hits         1523     1556      +33     
+ Misses        242      234       -8     
+ Partials       84       83       -1     
Files with missing lines Coverage Δ
synapse_token_authenticator/utils.py 90.90% <100.00%> (+0.90%) ⬆️
tests/test_oauth.py 100.00% <100.00%> (ø)
tests/test_sta_utils.py 97.50% <100.00%> (+0.53%) ⬆️
tests/__init__.py 89.56% <62.50%> (+1.96%) ⬆️
synapse_token_authenticator/claims_validator.py 77.60% <63.15%> (+0.85%) ⬆️
synapse_token_authenticator/config.py 68.81% <17.64%> (+1.62%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681a01d...84cfe25. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread synapse_token_authenticator/claims_validator.py
Comment thread synapse_token_authenticator/config.py Outdated
Comment thread synapse_token_authenticator/utils.py Outdated
@mzaniolo
mzaniolo force-pushed the mzaniolo/admin_path branch 2 times, most recently from f8edaf9 to 1fee2dc Compare July 30, 2025 07:26
@mzaniolo
mzaniolo requested a review from sirewix July 30, 2025 07:57
@mzaniolo
mzaniolo force-pushed the mzaniolo/admin_path branch from 1fee2dc to 84cfe25 Compare July 31, 2025 07:30
@mzaniolo
mzaniolo merged commit 84cfe25 into main Jul 31, 2025
3 checks passed
@mzaniolo
mzaniolo deleted the mzaniolo/admin_path branch July 31, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make admin_path accept an array of paths

2 participants