feat: add flag to redactEvent with edits FM-732

[krille-chan]

closes https://famedly.atlassian.net/browse/FM-732

[codecov]

Codecov Report

❌ Patch coverage is 28.12500% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.56%. Comparing base (c8afef4) to head (592f594).

Files with missing lines	Patch %	Lines
...with_rel_types/msc_3912_redact_with_rel_types.dart	0.00%	14 Missing ⚠️
lib/src/room.dart	40.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2389      +/-   ##
==========================================
- Coverage   59.61%   59.56%   -0.06%     
==========================================
  Files         161      162       +1     
  Lines       20308    20338      +30     
==========================================
+ Hits        12107    12114       +7     
- Misses       8201     8224      +23     

Files with missing lines	Coverage Δ
lib/src/event.dart	87.93% <100.00%> (+0.02%)	⬆️
lib/src/room.dart	75.82% <40.00%> (-0.47%)	⬇️
...with_rel_types/msc_3912_redact_with_rel_types.dart	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8afef4...592f594. Read the comment docs.

[cursor]

PR Summary

Medium Risk
Changes the redaction code path and can issue many redact requests on servers without MSC3912, which affects timeline content and server load.

Overview
Adds optional redactAllEdits on Event.redactEvent / Room.redactEvent so deleting a message can also remove its m.replace edit events, not just the root event.

When the flag is set, the client probes /versions for org.matrix.msc3912. Supported homeservers get a single redact via a new redactEventWithRelTypes API helper (MSC3912 with_rel_types). Otherwise the SDK loads related edits with getRelatingEventsWithRelType, redacts each edit (with rate-limit retry), then redacts the original event.

The MSC3912 extension is exported from matrix.dart. Timeline tests now exercise redactEvent(redactAllEdits: true) alongside aggregated edit display.

^{Reviewed by Cursor Bugbot for commit 592f594. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Autofix Details

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Edit fetch ignores pagination tokens
  • Manual edit redaction now paginates related m.replace events with from/nextBatch until all pages are processed.
• ✅ Fixed: Main redact lacks rate retry
  • The primary event redaction now uses the same retryAfterMs rate-limit retry path as edit redactions.

Or push these changes by commenting:

@cursor push ed4d881c74

Preview (ed4d881c74)

diff --git a/lib/src/room.dart b/lib/src/room.dart
--- a/lib/src/room.dart
+++ b/lib/src/room.dart
@@ -2491,24 +2491,47 @@
       );
     }
 
-    final edits = await client.getRelatingEventsWithRelType(
-      id,
-      eventId,
-      RelationshipTypes.edit,
-    );
-    for (final edit in edits.chunk) {
-      final txnid = client.generateUniqueTransactionId();
+    Future<String?> redactWithRateLimitRetry(
+      String redactionEventId,
+      String txid,
+    ) async {
       try {
-        await client.redactEvent(id, edit.eventId, txnid, reason: reason);
+        return await client.redactEvent(
+          id,
+          redactionEventId,
+          txid,
+          reason: reason,
+        );
       } on MatrixException catch (e) {
         final retryAfterMs = e.retryAfterMs;
         if (retryAfterMs == null) rethrow;
         await Future.delayed(Duration(milliseconds: retryAfterMs));
-        await client.redactEvent(id, edit.eventId, txnid, reason: reason);
+        return await client.redactEvent(
+          id,
+          redactionEventId,
+          txid,
+          reason: reason,
+        );
       }
     }
 
-    return await client.redactEvent(id, eventId, messageID, reason: reason);
+    String? nextBatch;
+    do {
+      final edits = await client.getRelatingEventsWithRelType(
+        id,
+        eventId,
+        RelationshipTypes.edit,
+        from: nextBatch,
+        limit: 50,
+      );
+      for (final edit in edits.chunk) {
+        final txnid = client.generateUniqueTransactionId();
+        await redactWithRateLimitRetry(edit.eventId, txnid);
+      }
+      nextBatch = edits.nextBatch;
+    } while (nextBatch != null);
+
+    return await redactWithRateLimitRetry(eventId, messageID);
   }
 
   /// This tells the server that the user is typing for the next N milliseconds

_{You can send follow-ups to the cloud agent here.}

[td-famedly]

@cursor review

[td-famedly]

async => await you don't need async await with fat arrow

[td-famedly]

mostly lg

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 592f594. Configure here.}