Skip to content

fix: Do not trace DBSettings, add base logging statements and return correct response to report request#91

Merged
skomski merged 3 commits into
mainfrom
kskomski/fix-dbsettings
Jul 25, 2025
Merged

fix: Do not trace DBSettings, add base logging statements and return correct response to report request#91
skomski merged 3 commits into
mainfrom
kskomski/fix-dbsettings

Conversation

@skomski

@skomski skomski commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@skomski
skomski requested a review from a team as a code owner July 24, 2025 16:57
@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 48.24%. Comparing base (ffa81fc) to head (6f8d982).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/settings.rs 0.00% 9 Missing ⚠️
src/server.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   50.98%   48.24%   -2.74%     
==========================================
  Files           5        5              
  Lines         253      257       +4     
==========================================
- Hits          129      124       -5     
- Misses        124      133       +9     
Files with missing lines Coverage Δ
src/database.rs 63.73% <ø> (-1.89%) ⬇️
src/server.rs 61.11% <66.66%> (-0.58%) ⬇️
src/settings.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa81fc...6f8d982. Read the comment docs.

@skomski
skomski force-pushed the kskomski/fix-dbsettings branch from bbf095b to 869bb45 Compare July 24, 2025 17:03
@skomski
skomski force-pushed the kskomski/fix-dbsettings branch 2 times, most recently from 3b2b9c6 to 1f13b0e Compare July 24, 2025 17:41
@skomski skomski changed the title fix: Do not trace DBSettings and add base logging statements fix: Do not trace DBSettings, add base logging statements and return correct response to report request Jul 24, 2025
@skomski
skomski force-pushed the kskomski/fix-dbsettings branch from 1f13b0e to 6f8d982 Compare July 25, 2025 09:06
Comment thread src/settings.rs
@skomski
skomski merged commit 6f8d982 into main Jul 25, 2025
6 of 7 checks passed
@skomski
skomski deleted the kskomski/fix-dbsettings branch July 25, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants