fix: Fix publish-crate checkout step#79
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4 #79 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 1 1
Lines 8 8
=======================================
Hits 4 4
Misses 4 4 Continue to review full report in Codecov by Sentry.
|
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: famedly/backend-build-workflows | ||
| ref: ${{ inputs.ref }} |
There was a problem hiding this comment.
what does it do? why does it need to checkout own repo?
There was a problem hiding this comment.
because just after the checkout we call ./.github/actions/rust-prepare and it won't be there if we don't checkout our own repo. The same thing is done in the rust-workflow
There was a problem hiding this comment.
Ah, we just used to call rust-prepare with absolute path. If for relative paths it still needs a checkout, I'd say we should get back to that. The very important part is versioning here, because this would checkout main iiuc. Having full absolute path to rust-prepare makes you wonder about the version, while having relative path makes you think that the version would match this workflow file commit version, while in fact it will be a completely different branch.
There was a problem hiding this comment.
I checked all version of the workflow they all work the same way. I'm more in favor of reproducible workflows where we always use tag as references. But, since the V4 is already used in many places I don't want to change the behavior here. I prefer to keep it as it is and change to a ref on the V5
3 participants
No description provided.