Use a docker entrypoint to perform environment setup instead of an action#45
Draft
tlater-famedly wants to merge 4 commits into
Draft
Use a docker entrypoint to perform environment setup instead of an action#45tlater-famedly wants to merge 4 commits into
tlater-famedly wants to merge 4 commits into
Conversation
tlater-famedly
marked this pull request as draft
January 27, 2025 06:33
tlater-famedly
commented
Jan 27, 2025
Contributor
Author
There was a problem hiding this comment.
I believe that we can't just rug-pull these in practice, we should probably make this a v2 branch if it happens.
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
10 times, most recently
from
January 28, 2025 09:07
37548dd to
5356c68
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 44.44% 44.44%
=======================================
Files 1 1
Lines 9 9
=======================================
Hits 4 4
Misses 5 5 Continue to review full report in Codecov by Sentry.
|
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
3 times, most recently
from
January 28, 2025 10:13
0f4e3a0 to
e084242
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
13 times, most recently
from
February 5, 2025 05:58
a41638b to
a827bd9
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
2 times, most recently
from
February 11, 2025 07:16
2fc550e to
b0162a0
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
7 times, most recently
from
February 28, 2025 11:12
34d2d48 to
9d2800b
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
3 times, most recently
from
April 2, 2025 11:05
9443b0b to
5ec5d3f
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
4 times, most recently
from
May 7, 2025 07:40
0a2c8bd to
6260351
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
8 times, most recently
from
May 7, 2025 09:20
9fc9de6 to
30ebece
Compare
tlater-famedly
force-pushed
the
tlater/docker-entrypoint
branch
from
May 7, 2025 09:27
30ebece to
184486e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on famedly/rust-container#11. This only introduces one commit on top of #44, review that one if you're curious.
This significantly simplifies the env setup (and modernizes it a bit, we have a lot of references to Gitlab still lying around), making this repository more robust to internal changes (since GitHub actions don't have a concept of dependencies, not even within the same repository).
Of course, this won't work for workflows in which we intend to run on bare metal instead of a container. This is primarily a problem when we want to launch additional containers; I believe that we can cover that use case with docker-in-docker instead, though, which I think is worth it.
Right now this is a draft so that I can test that last assertion there, feasibility all depends on that.