Skip to content

Use a docker entrypoint to perform environment setup instead of an action#45

Draft
tlater-famedly wants to merge 4 commits into
mainfrom
tlater/docker-entrypoint
Draft

Use a docker entrypoint to perform environment setup instead of an action#45
tlater-famedly wants to merge 4 commits into
mainfrom
tlater/docker-entrypoint

Conversation

@tlater-famedly

Copy link
Copy Markdown
Contributor

Depend on famedly/rust-container#11. This only introduces one commit on top of #44, review that one if you're curious.

This significantly simplifies the env setup (and modernizes it a bit, we have a lot of references to Gitlab still lying around), making this repository more robust to internal changes (since GitHub actions don't have a concept of dependencies, not even within the same repository).

Of course, this won't work for workflows in which we intend to run on bare metal instead of a container. This is primarily a problem when we want to launch additional containers; I believe that we can cover that use case with docker-in-docker instead, though, which I think is worth it.

Right now this is a draft so that I can test that last assertion there, feasibility all depends on that.

@tlater-famedly
tlater-famedly requested a review from a team as a code owner January 27, 2025 06:33
@tlater-famedly
tlater-famedly marked this pull request as draft January 27, 2025 06:33

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we can't just rug-pull these in practice, we should probably make this a v2 branch if it happens.

@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 10 times, most recently from 37548dd to 5356c68 Compare January 28, 2025 09:07
@codecov

codecov Bot commented Jan 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (31e5a07) to head (184486e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files           1        1           
  Lines           9        9           
=======================================
  Hits            4        4           
  Misses          5        5           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e5a07...184486e. Read the comment docs.

@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 3 times, most recently from 0f4e3a0 to e084242 Compare January 28, 2025 10:13
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 13 times, most recently from a41638b to a827bd9 Compare February 5, 2025 05:58
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 2 times, most recently from 2fc550e to b0162a0 Compare February 11, 2025 07:16
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 7 times, most recently from 34d2d48 to 9d2800b Compare February 28, 2025 11:12
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 3 times, most recently from 9443b0b to 5ec5d3f Compare April 2, 2025 11:05
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 4 times, most recently from 0a2c8bd to 6260351 Compare May 7, 2025 07:40
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch 8 times, most recently from 9fc9de6 to 30ebece Compare May 7, 2025 09:20
@tlater-famedly
tlater-famedly force-pushed the tlater/docker-entrypoint branch from 30ebece to 184486e Compare May 7, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants