Fix milestones card error#770
Conversation
## [2.93.1](v2.93.0...v2.93.1) (2026-07-08) ### Bug Fixes * 🐛 Extract timeline slide component to resolve hooks violation ([2e610af](2e610af))
|
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's GuideRefactors the horizontal event timeline carousel by extracting the slide rendering (including motion/gesture logic) into a dedicated TimelineSlide component to fix a hooks-in-loops violation, and bumps the package version with a corresponding changelog entry. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for getting this pull request merged. We appreciate your contribution and look forward to your next one! |
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
TimelineSlide, theonPanhandler still usese: any/info: any; consider typing these with the appropriate Framer Motion event/types (or at least_eif unused) to avoid leakinganyinto the component surface. - The z-index logic for slides (
isActive ? 60 : 30 - Math.abs(index - active)) is now inlined insideTimelineSlide; extracting this back into a small helper (e.g.zFor(index, active)) would make the intent clearer and avoid magic numbers in the JSX.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `TimelineSlide`, the `onPan` handler still uses `e: any`/`info: any`; consider typing these with the appropriate Framer Motion event/types (or at least `_e` if unused) to avoid leaking `any` into the component surface.
- The z-index logic for slides (`isActive ? 60 : 30 - Math.abs(index - active)`) is now inlined inside `TimelineSlide`; extracting this back into a small helper (e.g. `zFor(index, active)`) would make the intent clearer and avoid magic numbers in the JSX.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Extract the horizontal timeline slide into a dedicated component to fix a hooks usage issue and prepare a patch release.
Bug Fixes:
Enhancements:
Build: