It's great that you have lots of tests!
However... :)
- You should test for more than just a status code of 200 when receiving JSONs of data, e.g. what is the first item etc. I know this is making your tests dependent on the external API but you're depending on it already by expecting a 200. You can use Nock to avoid the dependency.
- Some tests are labelled wrongly, e.g. it says
index.html gives 500 error but you actually .expect() a 200
- Some tests don't seem very meaningful, e.g. checking that
/public/layouts/index.html gives you an error (unless I'm missing something)
- Remove comments from the workshop ;)
It's great that you have lots of tests!
However... :)
index.html gives 500 errorbut you actually.expect()a 200/public/layouts/index.htmlgives you an error (unless I'm missing something)