This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Register Nuclide File Tree: Rename/Delete commands at workspace level - #1433
Open
mrkev wants to merge 2 commits into
Open
Register Nuclide File Tree: Rename/Delete commands at workspace level#1433mrkev wants to merge 2 commits into
mrkev wants to merge 2 commits into
Conversation
velocityboy
suggested changes
Jan 11, 2018
velocityboy
left a comment
velocityboy
left a comment
Contributor
There was a problem hiding this comment.
For consistency with the other menu, can you change the text to "Delete Active File"?
Contributor
Author
|
Ah, certainly |
Contributor
Author
|
bump! |
Contributor
|
@velocityboy is currently on PTO! I imagine he'll reply in a few days |
Contributor
Author
|
Ah ok 😄 just making sure this doesn't get buried |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I found issue #822 and thought it'd be easy enough to just fix it. This is my first PR to the project, so apologies in advance if I missed something. All feedback is appreciated!