This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Set the correct MagicPython package dependency - #1426
Open
fed wants to merge 1 commit into
Open
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After installing Nuclide I've set it to automatically fetch and install all recommended packages. However, I've had this alert popping up every single time I opened Nuclide:
It looked like the MagicPython package was getting installed, but it actually wasn't (btw I'm running Atom 1.23.1, Nuclide 0.273.0 on MacOS High Sierra).
Tried installing it manually running
apm install MagicPythonbut it errored out:Not sure what's the deal with case sensitivity when it comes to Atom packages, but switching to the lowercase name version (as per the package site) seemed to do the trick:
Never got the "installing MagicPython" alert message again on boot up.
Not sure this is just me, but anyway I reckon this should be changed to reflect the actual name of the package.