Fix SDDL1 Syntax.md: record members are not comma-separated - #932
Open
avionicharshit-byte wants to merge 1 commit into
Open
Fix SDDL1 Syntax.md: record members are not comma-separated#932avionicharshit-byte wants to merge 1 commit into
avionicharshit-byte wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #931.
tools/sddl/compiler/Syntax.mddescribed record members as "a comma-separated list" and showed comma'd examples, but the SDDL1 compiler rejects commas in records (syntax error: Unexpected separator token ','). Members are separated like any other statements: newlines or semicolons.Updates the prose and removes the commas from the three affected examples (Row, the member-field forms, Header). All corrected examples verified against
sddl_compilerbuilt froma9de25e; the semicolon form was verified to compile too, so the new wording is accurate.