Skip to content

Add CBOR trace parser helper and smoke test for compression trace error testing (#557) - #557

Open
Victor-C-Zhang wants to merge 1 commit into
facebook:devfrom
Victor-C-Zhang:export-D97033481
Open

Add CBOR trace parser helper and smoke test for compression trace error testing (#557)#557
Victor-C-Zhang wants to merge 1 commit into
facebook:devfrom
Victor-C-Zhang:export-D97033481

Conversation

@Victor-C-Zhang

@Victor-C-Zhang Victor-C-Zhang commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Summary:
Add test infrastructure for E2E error propagation testing in compression tracing:

  • TraceTestHelpers.hpp: Header-only CBOR trace parser that decodes trace output
    from CCtx::getLatestTrace() into structured C++ types (ParsedTrace,
    ParsedChunk, ParsedCodec, ParsedGraph). Uses the a1cbor decode API with a
    test arena allocator.

  • CompressTraceErrorTest.cpp: Smoke test verifying the parse helper works on a
    real successful compression trace.

  • COMPRESS_TRACE_ERROR_TEST_PLAN.md: Plan document for implementing error
    propagation tests covering codec failures, graph failures, type conversion
    failures, segmenter failures, and deduplication logic.

Differential Revision: D97033481

Pulled By: Victor-C-Zhang

@meta-cla meta-cla Bot added the cla signed label Mar 26, 2026
@meta-codesync

meta-codesync Bot commented Mar 26, 2026

Copy link
Copy Markdown

@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97033481.

@meta-codesync

meta-codesync Bot commented Mar 27, 2026

Copy link
Copy Markdown

@Victor-C-Zhang has imported this pull request. If you are a Meta employee, you can view this in D97033481.

…or testing (facebook#557)

Summary:
Add test infrastructure for E2E error propagation testing in compression tracing:

- `TraceTestHelpers.hpp`: Header-only CBOR trace parser that decodes trace output
  from `CCtx::getLatestTrace()` into structured C++ types (`ParsedTrace`,
  `ParsedChunk`, `ParsedCodec`, `ParsedGraph`). Uses the a1cbor decode API with a
  test arena allocator.

- `CompressTraceErrorTest.cpp`: Smoke test verifying the parse helper works on a
  real successful compression trace.

- `COMPRESS_TRACE_ERROR_TEST_PLAN.md`: Plan document for implementing error
  propagation tests covering codec failures, graph failures, type conversion
  failures, segmenter failures, and deduplication logic.

Differential Revision: D97033481

Pulled By: Victor-C-Zhang
@meta-codesync meta-codesync Bot changed the title Add CBOR trace parser helper and smoke test for compression trace error testing Add CBOR trace parser helper and smoke test for compression trace error testing (#557) Mar 27, 2026
meta-codesync Bot pushed a commit that referenced this pull request Mar 27, 2026
…or testing (#557)

Summary:
Add test infrastructure for E2E error propagation testing in compression tracing:

- `TraceTestHelpers.hpp`: Header-only CBOR trace parser that decodes trace output
  from `CCtx::getLatestTrace()` into structured C++ types (`ParsedTrace`,
  `ParsedChunk`, `ParsedCodec`, `ParsedGraph`). Uses the a1cbor decode API with a
  test arena allocator.

- `CompressTraceErrorTest.cpp`: Smoke test verifying the parse helper works on a
  real successful compression trace.

- `COMPRESS_TRACE_ERROR_TEST_PLAN.md`: Plan document for implementing error
  propagation tests covering codec failures, graph failures, type conversion
  failures, segmenter failures, and deduplication logic.

Differential Revision: D97033481

Pulled By: Victor-C-Zhang

fbshipit-source-id: ad848561696ef5e1d7b6848368709c34837debf9
@meta-cla

meta-cla Bot commented Jul 25, 2026

Copy link
Copy Markdown

Hi @Victor-C-Zhang!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant