Fix test-linux-armv7 job for forks not named "hermes"#2047
Closed
ramonclaudio wants to merge 1 commit into
Closed
Conversation
The test-linux-armv7 job uses actions/checkout@v1 (kept on purpose because v4 fails inside the arm32 container, see actions/checkout#334), which checks the repo out into a directory named after the repository. The build step then does `cd ..` and runs `cmake -S hermes` and `python3 hermes/utils/...`, hardcoding the repo name. On any fork whose name is not "hermes" the checkout lands in <fork-name>/ and the build fails immediately: CMake Error: The source directory /__w/<fork>/hermes does not exist. Reference the checkout directory via ${{ github.event.repository.name }} so the path follows the repo name. It resolves to "hermes" on facebook/hermes (no behavior change) and to the fork name on forks. The other six jobs are already fork-agnostic because they use actions/checkout@v4.1.0 with `path: hermes`.
meta-cla
Bot
added
the
CLA Signed
|
@tmikov has imported this pull request. If you are a Meta employee, you can view this in D107691575. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
test-linux-armv7job hardcodes the repo name (cmake -S hermes,python3 hermes/utils/...), so it fails on any fork not namedhermes:Unlike the other jobs, it uses
actions/checkout@v1withoutpath:(v4 breaks in the arm32 container, actions/checkout#334), so the checkout directory takes the repo name. Swap the hardcodedhermesfor${{ github.event.repository.name }}: unchanged onfacebook/hermes, correct on forks.Test plan
actionlintclean, YAML valid.hermesupstream, so the commands are unchanged here.