Optimize bigint division for fast path#2039
Conversation
Issue facebook#1850 reported that bigint division could be optimized for the case where lhs.numDigits < rhs.numDigits. When the left-hand side has fewer digits than the right-hand side, the mathematical result is straightforward: - Quotient: 0 (the divisor is larger than the dividend) - Remainder: lhs (unchanged) This optimization avoids the expensive tcDivide computation, reducing complexity from O(n²) to O(n) for this common case. Performance impact: Significant speedup for bigint divisions where the dividend is much smaller than the divisor. Fixes facebook#1850 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Hi @vigneshakaviki! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
Changes
Performance Impact
Test Plan