feat: add interactive binding cards to serve landing page#52
Draft
adnrivera wants to merge 1 commit into
Draft
Conversation
Render each binding as an interactive card on the `serve` landing page. A card's title links through the server's `/?cmd=` redirect, and a JS-free GET form lets users type arguments: the command travels in a hidden `cmd` field and the visible field carries the user's `args`, which the server combines into `cmd args` (e.g. `threads` + `zuck` -> `threads zuck`). Add a helper in `server/mod.rs` to combine the `cmd` and `args` query parameters, and pass the resolved `display_url` into `BindingCard` so links and form actions use the configured public URL. Add integration tests covering the serve route, the cards feature, and the end-to-end arguments-form redirect.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render each binding as an interactive card on the
servelanding page. A card's title links through the server's/?cmd=redirect, and a JS-free GET form lets users type arguments: the command travels in a hiddencmdfield and the visible field carries the user'sargs, which the server combines intocmd args(e.g.threads+zuck->threads zuck).Add a helper in
server/mod.rsto combine thecmdandargsquery parameters, and pass the resolveddisplay_urlintoBindingCardso links and form actions use the configured public URL.Add integration tests covering the serve route, the cards feature, and the end-to-end arguments-form redirect.