Add flags support to benchmarks to report log/set/userspace benchmarks specificities#546
Merged
Merged
Conversation
qdeslandes
force-pushed
the
report_benchmark_flags
branch
from
b0a2fad to
2928bd3
Compare
Introduce bft::benchmark::Flags and set_flags() to annotate benchmarks with use_set, use_log, and userspace_only counters. These appear in the JSON output so tooling can filter out flaky or non-execution benchmarks without relying on name prefixes.
Parse use_set, use_log, and userspace_only counters from the benchmark JSON output into Result, bubble them up through Benchmark and BenchmarkRow, and render them as badge pills in the HTML report table.
qdeslandes
force-pushed
the
report_benchmark_flags
branch
from
2928bd3 to
aedfd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks results can be influenced by the matchers used:
Those flags are reflected in the benchmark results, and in the HTML report.
Those flags will be used to later in
bfoptimizerto detect benchmarks results to ignore.