fix(core): forward rest props in ChatSendButton, use radius token in CheckboxInput#4258
Open
cixzhang wants to merge 1 commit into
Open
fix(core): forward rest props in ChatSendButton, use radius token in CheckboxInput#4258cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
…CheckboxInput ChatSendButton extended BaseProps but silently dropped className, style, data-testid, and all pass-through attributes. Capture ...rest and forward to the underlying Button. CheckboxInput indeterminate mark used a hardcoded borderRadius: 1 instead of the radius-full token.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
needs:design-review
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
July 23, 2026 10:47
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsChat · View in Storybook
CheckboxInput · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 serious. Chat - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two convention fixes found during component audit of Chat, CheckboxInput,
CheckboxList, Citation, and ClickableCard.
ChatSendButton (structure-issue): Extended
BaseProps<HTMLButtonElement>butdestructured only named props without a rest capture. Pass-through attributes
(
className,style,data-testid, event handlers,aria-*) were silentlydropped. Now captures
...restand forwards it, along withclassName,style,and
data-testid, to the underlying Button.CheckboxInput (hardcoded-value): The indeterminate mark bar used
borderRadius: 1(hardcoded) instead ofradiusVars['--radius-full']. Functionallyidentical on the 2px-tall element but now uses the token for consistency.
Components Audited (clean)
Night Watch -- Component Auditor