Decouple parameter discovery from data extraction in _get_fit_args (#5200)#5200
Open
hvarfner wants to merge 1 commit into
Open
Decouple parameter discovery from data extraction in _get_fit_args (#5200)#5200hvarfner wants to merge 1 commit into
hvarfner wants to merge 1 commit into
Conversation
hvarfner
force-pushed
the
export-D104702983
branch
from
aac1f43 to
10b36ec
Compare
meta-cla
Bot
added
the
CLA Signed
|
@hvarfner has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104702983. |
meta-codesync
Bot
changed the title
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
May 11, 2026
…acebook#5200) Summary: Pull Request resolved: facebook#5200 Adds a `data_parameters` argument to `TorchAdapter._get_fit_args` that decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set `_model_space` to include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the `_expand_ssd_to_joint_space` post-hoc expansion. Overrides `_set_search_space` to add source-only RangeParameters from the joint search space to `_model_space` while preserving target bounds for shared params (Normalize stays anchored to target bounds). At gen time, `self.parameters` is temporarily swapped to target-only so `extract_search_space_digest` sees only params present in the gen-time search space. Deletes `_expand_ssd_to_joint_space` (~90 lines). Differential Revision: D104702983
hvarfner
force-pushed
the
export-D104702983
branch
from
10b36ec to
fda67a6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5200 +/- ##
==========================================
+ Coverage 96.38% 96.51% +0.12%
==========================================
Files 617 617
Lines 69615 69617 +2
==========================================
+ Hits 67100 67188 +88
+ Misses 2515 2429 -86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
May 12, 2026
…acebook#5200) Summary: Adds a `data_parameters` argument to `TorchAdapter._get_fit_args` that decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set `_model_space` to include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the `_expand_ssd_to_joint_space` post-hoc expansion. Overrides `_set_search_space` to add source-only RangeParameters from the joint search space to `_model_space` while preserving target bounds for shared params (Normalize stays anchored to target bounds). At gen time, `self.parameters` is temporarily swapped to target-only so `extract_search_space_digest` sees only params present in the gen-time search space. Deletes `_expand_ssd_to_joint_space` (~90 lines). Differential Revision: D104702983
hvarfner
force-pushed
the
export-D104702983
branch
from
fda67a6 to
b99282d
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
May 12, 2026
…acebook#5200) Summary: Adds a `data_parameters` argument to `TorchAdapter._get_fit_args` that decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set `_model_space` to include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the `_expand_ssd_to_joint_space` post-hoc expansion. Overrides `_set_search_space` to add source-only RangeParameters from the joint search space to `_model_space` while preserving target bounds for shared params (Normalize stays anchored to target bounds). At gen time, `self.parameters` is temporarily swapped to target-only so `extract_search_space_digest` sees only params present in the gen-time search space. Deletes `_expand_ssd_to_joint_space` (~90 lines). Differential Revision: D104702983
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
May 14, 2026
…acebook#5200) Summary: Adds a `data_parameters` argument to `TorchAdapter._get_fit_args` that decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set `_model_space` to include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the `_expand_ssd_to_joint_space` post-hoc expansion. Overrides `_set_search_space` to add source-only RangeParameters from the joint search space to `_model_space` while preserving target bounds for shared params (Normalize stays anchored to target bounds). At gen time, `self.parameters` is temporarily swapped to target-only so `extract_search_space_digest` sees only params present in the gen-time search space. Deletes `_expand_ssd_to_joint_space` (~90 lines). Differential Revision: D104702983
hvarfner
force-pushed
the
export-D104702983
branch
from
b99282d to
080fb36
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
May 14, 2026
…acebook#5200) Summary: **Motivation:** model_space/search_space was not properly used - parameter bounds on the search space would be set from the union of source and target, and parameters that were fixed on the target would be RangeParameters if the model_space contained a Fixed/Range change in the parameter. Adds a `data_parameters` argument to `TorchAdapter._get_fit_args` that decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set `_model_space` to include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the `_expand_ssd_to_joint_space` post-hoc expansion. Differential Revision: D104702983
…acebook#5200) Summary: **Motivation:** model_space/search_space was not properly used - parameter bounds on the search space would be set from the union of source and target, and parameters that were fixed on the target would be RangeParameters if the model_space contained a Fixed/Range change in the parameter. Adds a `data_parameters` argument to `TorchAdapter._get_fit_args` that decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set `_model_space` to include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the `_expand_ssd_to_joint_space` post-hoc expansion. Reviewed By: saitcakmak Differential Revision: D104702983
hvarfner
force-pushed
the
export-D104702983
branch
from
080fb36 to
f99000b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation: model_space/search_space was not properly used - parameter bounds on the search space would be set from the union of source and target, and parameters that were fixed on the target would be RangeParameters if the model_space contained a Fixed/Range change in the parameter.
Adds a
data_parametersargument toTorchAdapter._get_fit_argsthat decouples SSD construction (model params) from data column extraction (target params). This lets the TL adapter set_model_spaceto include source-only RangeParameters directly, so the SSD naturally covers the full joint feature space -- eliminating the need for the_expand_ssd_to_joint_spacepost-hoc expansion.Reviewed By: saitcakmak
Differential Revision: D104702983