Enable BestTrials for Online Experiments

[shrutipatel31]

Summary:
Pass use_model_predictions=has_batch_trials to BestTrials in ResultsAnalysis.

Online experiments (which use BatchTrials) get GP model predictions for noise smoothing via shrinkage. AutoML and other direct callers get the default (False).

Per design meeting 3/26: 'If online experiment, set model_predictions=True. If AutoML, say False. Set based on if has batch trials or not. For now.'

Generated by Metamate
Metamate Session, Trace

Differential Revision: D99128865

[meta-codesync]

@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99128865.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (4ebc621) to head (2f76d18).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5129   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         613      613           
  Lines       68171    68193   +22     
=======================================
+ Hits        65721    65743   +22     
  Misses       2450     2450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[meta-cla]

Hi @shrutipatel31!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!