fix TypeError when using \Phalcon\Mvc\View\Simple::render#69
Open
mzf wants to merge 1 commit into
Open
Conversation
sergeyklay
approved these changes
May 4, 2017
fabfuel
reviewed
May 16, 2017
| public function beforeRenderView(Event $event, ViewInterface $view) | ||
| { | ||
| $name = get_class($event->getSource()) . '::render: ' . basename($view->getActiveRenderPath()); | ||
| $isViewSimpler = stripos(get_class($view), 'simple') !== false; |
Owner
There was a problem hiding this comment.
Why isViewSimpler (with an "r") instead of isViewSimple? Typo?
Owner
There was a problem hiding this comment.
And why don't you check the class via instanceof?
Owner
|
Looks like the branch is outdated. Please update with |
|
@mzf Could you please rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#68