Skip to content

Add emojis for different sources - #100

Merged
f-ewald merged 2 commits into
mainfrom
feature/source-emojis
Jan 14, 2026
Merged

Add emojis for different sources#100
f-ewald merged 2 commits into
mainfrom
feature/source-emojis

Conversation

@f-ewald

@f-ewald f-ewald commented Jan 14, 2026

Copy link
Copy Markdown
Owner

This change adds the octopus emoji for Github entries and the handwritten pencil emoji for manual entries to be able to distinguish the entries more easily visually.

This change adds the octopus emoji for Github entries and the handwritten pencil emoji for manual entries to be able to distinguish the entries more easily visually.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds emoji prefixes to distinguish log entries from different sources visually. GitHub entries get an octopus emoji (🐙) and manual entries get a handwritten pencil emoji (✍️).

Changes:

  • Added source_prefix method to BaseFormatter that returns emoji prefixes based on log entry source
  • Integrated the source prefix into the format method of BaseFormatter
  • Added unit tests for the new source_prefix method

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/log_entry_formatters.rb Implements the source_prefix method and integrates it into the format method to prepend emojis based on source
test/log_entry_formatters_test.rb Adds unit tests to verify correct emoji prefixes for different sources
Comments suppressed due to low confidence (1)

test/log_entry_formatters_test.rb:39

  • The test_console_formatter should be updated to verify that the source prefix is included in the formatted output. Since the @log_entry in setup doesn't specify a source, it defaults to 'manual' (per LogEntry initialization), so the test should assert that '✍️ ' appears in the formatted message. This would provide integration test coverage for the new feature.
  def test_console_formatter
    formatter = LogEntryFormatters::ConsoleFormatter.new(@known_people)
    formatted_message = formatter.format(@log_entry)

    assert_includes formatted_message, 'Alice Smith'
    assert_includes formatted_message, 'Bob Johnson'
    assert_includes formatted_message, 'PROJ-123'
  end

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/log_entry_formatters.rb

Copilot AI commented Jan 14, 2026

Copy link
Copy Markdown

@f-ewald I've opened a new pull request, #101, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Add YARD documentation to source_prefix method

Co-authored-by: f-ewald <1391977+f-ewald@users.noreply.github.com>

* Fix capitalization in YARD documentation

Co-authored-by: f-ewald <1391977+f-ewald@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: f-ewald <1391977+f-ewald@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Complexity Health
worklog 79% 0
Summary 79% (742 / 944) 0

@f-ewald
f-ewald merged commit 1452613 into main Jan 14, 2026
1 check passed
@f-ewald
f-ewald deleted the feature/source-emojis branch January 14, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants