fix(fund): show a clear 'verification in progress' state instead of nagging KYC#1670
Merged
Merged
Conversation
…agging KYC
After the participant completes iDEAL, the payment provider puts the bank
account in a review state ("pending") but often still returns a
verification_url. prepare_payout matched by URL first and returned
:kyc_required, so we kept showing the "please verify your bank account"
modal for several minutes — even though the participant had done
everything they could.
Fix: match on the bank status first ("new" is the only actionable state;
any other non-approved status means the provider is reviewing) and add a
new {:error, :awaiting_verification} branch. RewardsSummaryView routes
it to a "verification in progress, please try again shortly" info modal
(single OK button, no redirect). Also extend Pixel.ConfirmationModal
with cancel_label: nil to render info-only variants.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JoeriDijkstra
approved these changes
Jul 23, 2026
| # other non-approved status ("pending", etc.) means the provider is reviewing | ||
| # and the participant just needs to wait, even if a stale verification_url is | ||
| # still returned — so match on status first, URL second. | ||
| defp payout_ready_for(%{status: "new", verification_url: verification_url}) |
Contributor
There was a problem hiding this comment.
This is something that is going to change, since we're going to store the status differently, but I'll pick that up in my branch after merging this
…on-waiting-state # Conflicts: # core/priv/gettext/de/LC_MESSAGES/eyra-assignment.po # core/priv/gettext/en/LC_MESSAGES/eyra-assignment.po # core/priv/gettext/es/LC_MESSAGES/eyra-assignment.po # core/priv/gettext/eyra-assignment.pot # core/priv/gettext/it/LC_MESSAGES/eyra-assignment.po # core/priv/gettext/lt/LC_MESSAGES/eyra-assignment.po # core/priv/gettext/nl/LC_MESSAGES/eyra-assignment.po # core/priv/gettext/ro/LC_MESSAGES/eyra-assignment.po
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FX#10005449329 — https://3.basecamp.com/5734045/buckets/35926565/todos/10005449329
Test plan
🤖 Generated with Claude Code