feat(cli): add Platform login for Experiential Cloud - #602
Merged
Conversation
kfallah
marked this pull request as ready for review
August 22, 2026 22:10
Contributor
Greptile SummaryThe PR adds browser-based Experiential Cloud authentication to interactive provider setup and makes the hosted provider the first picker option.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; both previously reported issues are addressed by callback key-shape validation and the immediate browser-failure fallback.
|
| Filename | Overview |
|---|---|
| exp/cli/providers/experiential_cloud.py | Adds the loopback browser-login flow and now rejects malformed callback keys while returning immediately when browser launch fails. |
| exp/cli/providers/provider_picker.py | Places Experiential Cloud first and integrates Platform login ahead of the existing masked credential prompt. |
| exp/cli/providers/experiential_cloud_test.py | Covers callback authorization, malformed callback rejection, credential secrecy, successful browser approval, and browser-unavailable fallback. |
| exp/cli/providers/provider_picker_test.py | Updates picker-order expectations and verifies that browser-approved Cloud credentials enter the existing setup and storage flow. |
Sequence Diagram
sequenceDiagram
actor User
participant CLI
participant Callback as Loopback callback
participant Platform
participant Store as User auth store
CLI->>Callback: Bind ephemeral 127.0.0.1 port
CLI->>Platform: Open /cli/auth with port and state
User->>Platform: Approve CLI key
Platform->>Callback: Return xpl_ key and matching state
Callback-->>CLI: Release validated key
CLI->>Platform: Discover models using key
CLI->>Store: Persist credential
alt Browser cannot open
CLI-->>User: Show URL and masked-paste fallback
end
Reviews (2): Last reviewed commit: "fix(cli): harden Platform login fallback" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
uv run --extra dev ruff check .uv run --extra dev ruff format --check .uv run --extra dev ty check expuv run --extra dev python -m pytest -q exp/cli/providers/experiential_cloud_test.py exp/cli/providers/provider_picker_test.py exp/cli/providers/setup_test.py exp/cli/gateway/setup_test.py exp/cli/optimize/router_candidates_test.py::test_router_candidate_picker_discovers_only_eligible_completion_models(99 passed)The live Platform flow is exercised with a local callback fixture; no real credential was minted during tests.