fix(transform): compare resolved DuckDB paths in dev-target preflight - #234
Merged
marcociav-exmergo merged 2 commits intoAug 7, 2026
Conversation
marcociav-exmergo
requested changes
Aug 5, 2026
marcociav-exmergo
left a comment
marcociav-exmergo
left a comment
Member
There was a problem hiding this comment.
@AshSgDe29071999 thanks for this. pls add a brief summary of your changes to the CHANGELOG.MD, under Unreleased
Contributor
Author
|
Added Unreleased CHANGELOG entry for the DuckDB path-normalize preflight fix. |
AshSgDe29071999
force-pushed
the
fix/dev-target-duckdb-path-normalize
branch
from
August 7, 2026 12:50
b0e727a to
bfc3537
Compare
marcociav-exmergo
requested changes
Aug 7, 2026
marcociav-exmergo
left a comment
marcociav-exmergo
left a comment
Member
There was a problem hiding this comment.
@AshSgDe29071999 , looks good!
Just fix the ruff linter issues and the merge conflicts, then we can merge
Closes exmergo#196 warehouse.duckdb vs ./warehouse.duckdb vs absolute paths named the same file but string compare refused the build. Resolve config and profile paths before comparing; show resolved forms when they still differ.
Contributor
Author
AshSgDe29071999
force-pushed
the
fix/dev-target-duckdb-path-normalize
branch
from
August 7, 2026 13:09
4e191d3 to
62db1d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dev-target preflight compared DuckDB paths as raw strings, so
warehouse.duckdb,./warehouse.duckdb, and absolute paths to the same file were treated as drift.Changes
Closes #196