ci: fail when the architecture validator drifts from core - #91
Merged
Conversation
The validator here is a verbatim copy of the canonical file in exelearning/exelearning. Until now nothing enforced that: the copies stayed identical only because whoever changed one remembered to re-copy the rest. Twice during the recent review rounds that memory was the only safeguard, and once a sync commit was lost without anyone noticing for hours. The step fetches the canonical file from core's default branch and diffs it against this copy. A drift fails the job and prints the diff, so the report says what changed rather than just that something did. It needs no dependency and no setup: curl and diff are on the runner.
Contributor
Test in WordPress PlaygroundTest the plugin with the code from this branch:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 96.87% 96.87%
Complexity 864 864
=========================================
Files 39 39
Lines 4323 4323
=========================================
Hits 4188 4188
Misses 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: fail when the architecture validator drifts from core
The validator here is a verbatim copy of the canonical file in
exelearning/exelearning. Until now nothing enforced that: the copies stayed
identical only because whoever changed one remembered to re-copy the rest.
Twice during the recent review rounds that memory was the only safeguard,
and once a sync commit was lost without anyone noticing for hours.
The step fetches the canonical file from core's default branch and diffs it
against this copy. A drift fails the job and prints the diff, so the report
says what changed rather than just that something did.
It needs no dependency and no setup: curl and diff are on the runner.
Verified locally: the step passes against the current copy, and fails with a readable diff when a line is appended to it.