chore(deps): keep React aligned with WordPress - #100
Merged
Conversation
Contributor
Test in WordPress PlaygroundTest the plugin with the code from this branch:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=========================================
Coverage 96.87% 96.87%
Complexity 864 864
=========================================
Files 39 39
Lines 4323 4323
=========================================
Hits 4188 4188
Misses 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reactandreact-domto18.3.1package-lock.jsonaligned with the manifestWhy
The grouped React 19 update in #98 resolves the npm peer dependency conflict, but the JavaScript test suite then mixes React elements created by
@wordpress/element@8.4.0withreact-dom@19. React 19 rejects elements created by the React 18 runtime shipped through the current WordPress packages.The test environment also consumes
@testing-library/react, which declares React and React DOM as peer dependencies. Keeping both packages explicit avoids relying on transitive dependency hoisting.Impact
React remains aligned with the version used by the current WordPress package set. Dependabot can still group compatible updates, but it will not open automatic major-version updates until the WordPress dependencies are ready for React 19.
Validation
.github/dependabot.ymlreactandreact-dompackage.jsonand the root lockfile declarations use18.3.1react@18.3.1andreact-dom@18.3.1