Skip to content

chore(deps): keep React aligned with WordPress - #100

Merged
erseco merged 3 commits into
mainfrom
agent/keep-wordpress-react-18
Aug 11, 2026
Merged

chore(deps): keep React aligned with WordPress#100
erseco merged 3 commits into
mainfrom
agent/keep-wordpress-react-18

Conversation

@erseco

@erseco erseco commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pin react and react-dom to 18.3.1
  • keep package-lock.json aligned with the manifest
  • keep React dependency updates grouped
  • ignore major React and React DOM updates in Dependabot

Why

The grouped React 19 update in #98 resolves the npm peer dependency conflict, but the JavaScript test suite then mixes React elements created by @wordpress/element@8.4.0 with react-dom@19. React 19 rejects elements created by the React 18 runtime shipped through the current WordPress packages.

The test environment also consumes @testing-library/react, which declares React and React DOM as peer dependencies. Keeping both packages explicit avoids relying on transitive dependency hoisting.

Impact

React remains aligned with the version used by the current WordPress package set. Dependabot can still group compatible updates, but it will not open automatic major-version updates until the WordPress dependencies are ready for React 19.

Validation

  • parsed the updated .github/dependabot.yml
  • verified the React group contains exactly react and react-dom
  • verified both major-version ignore rules
  • verified package.json and the root lockfile declarations use 18.3.1
  • verified the lockfile resolves one root react@18.3.1 and react-dom@18.3.1

@github-actions

Copy link
Copy Markdown
Contributor

Test in WordPress Playground

Test the plugin with the code from this branch:

Preview in WordPress Playground

ℹ️ The eXeLearning editor is fetched from the shared release and unpacked into the plugin when the playground boots, so the first load may take a few extra seconds. ELP upload, shortcode, Gutenberg block and preview work normally.

@codecov-commenter

codecov-commenter commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.87%. Comparing base (75f51a9) to head (9cebef9).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #100   +/-   ##
=========================================
  Coverage     96.87%   96.87%           
  Complexity      864      864           
=========================================
  Files            39       39           
  Lines          4323     4323           
=========================================
  Hits           4188     4188           
  Misses          135      135           
Flag Coverage Δ
javascript 95.70% <ø> (ø)
php 97.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erseco
erseco marked this pull request as ready for review August 11, 2026 17:23
@erseco
erseco merged commit 0a61240 into main Aug 11, 2026
6 checks passed
@erseco
erseco deleted the agent/keep-wordpress-react-18 branch August 11, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants