Skip to content

deps: upgrade celestia dependencies #3252

Open
tac0turtle wants to merge 1 commit intomainfrom
deps/celestia-app-v8.0.1-mocha-node-v0.30.2-mocha
Open

deps: upgrade celestia dependencies #3252
tac0turtle wants to merge 1 commit intomainfrom
deps/celestia-app-v8.0.1-mocha-node-v0.30.2-mocha

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

Updates testing configuration to use newer versions as requested in #3243.

Overview

….2-mocha

Updates testing configuration to use newer versions as requested in #3243.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

Warning

Rate limit exceeded

@tac0turtle has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 28 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 45 minutes and 28 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: adf06093-391b-418a-8137-1e549f0d3680

📥 Commits

Reviewing files that changed from the base of the PR and between 50a73fb and a054877.

📒 Files selected for processing (4)
  • docs/.vitepress/constants/constants.js
  • test/docker-e2e/docker_test.go
  • test/e2e/da_client_integration_test.go
  • test/e2e/da_posting_integration_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/celestia-app-v8.0.1-mocha-node-v0.30.2-mocha

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 14, 2026, 1:33 PM

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 14, 2026

Claude finished @tac0turtle's task in 1m 15s —— View job


Code Review

  • Gather context and read CLAUDE.md / AGENTS.md
  • Read changed files
  • Analyze changes and provide review

Summary

This PR bumps Celestia dependency versions used in test infrastructure and documentation:

Dependency Before After
celestia-app (docker-e2e) v5.0.2 v8.0.1-mocha
celestia-app (e2e tests) v5.0.10 v8.0.1-mocha
celestia-node (docker-e2e) v0.25.3 v0.30.2-mocha
celestia-node (e2e da_client) v0.26.4 v0.30.2-mocha
celestia-node (e2e da_posting) v0.28.4-mocha v0.30.2-mocha
celestiaNodeMochaTag (docs) v0.23.4-mocha v0.30.2-mocha

The changes are straightforward version bumps with no structural changes.


Observations

Positive

  • All test files now use a consistent pair of versions (v8.0.1-mocha / v0.30.2-mocha), resolving the previous inconsistencies where files used different versions of the same dependency.
  • The docs constant (celestiaNodeMochaTag) is now in sync with what tests actually use.

Minor: hardcoded versions vs. constants (test/e2e/da_client_integration_test.go:61-63, test/e2e/da_posting_integration_test.go:61-63)

docker_test.go uses a named constant celestiaAppVersion for the app image version, but the two e2e test files hardcode the version string inline. If the versions need to change again, all three files must be updated. A small quality-of-life improvement would be to define shared constants (e.g. in a testconst.go under test/e2e/). Not a blocker, but worth noting for future bumps.

Minor: no constant for celestia-node version in docker_test.go (test/docker-e2e/docker_test.go:154)

celestiaAppVersion is declared as a constant, but the celestia-node version is still an inline literal. Symmetry would suggest a celestiaNodeVersion constant alongside celestiaAppVersion. Fix this →

Note: large version jump for celestia-app (v5 → v8)

The celestia-app jump spans three major versions. Since these tests actually spin up Docker containers against the real network binary, compatibility will be validated at runtime. Just worth confirming CI passes with the new versions before merging.


Verdict

The changes are clean, focused, and correct for their purpose. No blocking issues. The minor inconsistencies around where version strings are defined are pre-existing and out of scope for this PR.

@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://evstack.github.io/docs-preview/pr-3252/

Built to branch main at 2026-04-14 13:36 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.79%. Comparing base (50a73fb) to head (a054877).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3252   +/-   ##
=======================================
  Coverage   61.79%   61.79%           
=======================================
  Files         120      120           
  Lines       12670    12670           
=======================================
  Hits         7830     7830           
  Misses       3962     3962           
  Partials      878      878           
Flag Coverage Δ
combined 61.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants