Fix missing summary items in recurring & disbursement payment fallback - #69
Merged
ana-maksimovskikh merged 4 commits intoAug 23, 2026
Merged
Conversation
Jake Grogan (jakekgrog)
approved these changes
Aug 21, 2026
ana-maksimovskikh
force-pushed
the
ana/apple-pay-fix-recurring-payment-summary-fallback
branch
from
August 23, 2026 11:33
97b591c to
5c81d2e
Compare
ana-maksimovskikh
deleted the
ana/apple-pay-fix-recurring-payment-summary-fallback
branch
August 23, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
getPaymentSummaryItems()is the fallback PassKit calls whenever the merchant delegate doesn't handle a shipping/payment-method/coupon-code update itself. For recurring and disbursement transactions, it only returned the plain paymentSummaryItems list — it never included:So any mid-sheet update (changing shipping address, switching card, entering a coupon) would silently drop these required line items — including the total — from the Apple Pay sheet.
Fix
getPaymentSummaryItems()now appends the same itemsbuildPaymentRequestalready builds for these transaction types, so the fallback stays consistent with the initial request.Tests
Added regression tests covering all three fallback entry points (
didChangeCouponCode,didSelectShippingContact,didSelectPaymentMethod) against both affected transaction types.Before / After